Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browse the last deployments #617

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

SteBaum
Copy link
Contributor

@SteBaum SteBaum commented Jul 26, 2024

Which issue(s) this PR fixes

Fixes #616

Additional comments

Changed the order in query. Now showing the deployments in descending order.

Agreements

@SteBaum SteBaum self-assigned this Jul 26, 2024
@PACordonnier
Copy link
Member

Thanks @SteBaum. I just tried and it works. I reconsider what I said during the meeting and would rather have the most recent deployment at the end of the output, it makes more sense in a CLI. @rpignolet was right ! Can you modify it ?

Also, I think this is a fix rather than a refactor.

@rpignolet
Copy link
Collaborator

We should talk about it with @PaulFarault how to fix that (find the good query to do the job)

@SteBaum SteBaum requested a review from PaulFarault July 26, 2024 14:48
@SteBaum SteBaum force-pushed the stephan/refactor/get_deployments branch from 8de63fa to 7d3f55a Compare August 5, 2024 13:20
@SteBaum
Copy link
Contributor Author

SteBaum commented Aug 5, 2024

@PACordonnier see if it suits you now. The query returns the last deployments (15 by default) in ascending order.

@PACordonnier
Copy link
Member

Works perfect thanks

Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should talk about it with @PaulFarault how to fix that (find the good query to do the job)

This is the correct query to modify. However, the offset seems to be broken in this new version. It should be located next to the limit.

@PaulFarault PaulFarault self-assigned this Oct 22, 2024
@PaulFarault PaulFarault removed the request for review from rpignolet October 22, 2024 10:43
Fixes #616 return the last deployments insteads of the firsts
@PaulFarault PaulFarault force-pushed the stephan/refactor/get_deployments branch from 316d5c3 to 9e8d786 Compare October 22, 2024 10:44
@PaulFarault PaulFarault requested a review from rpignolet October 22, 2024 10:45
@PaulFarault PaulFarault changed the title refactor: changed the order to descendant for get_deployments query browse the last deployments Oct 22, 2024
@PaulFarault PaulFarault merged commit f342dcd into master Oct 23, 2024
5 checks passed
@PaulFarault PaulFarault deleted the stephan/refactor/get_deployments branch October 23, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tdp browse should show last X deployments instead of first X
4 participants